feat(rule): add resolve references for targetgroups #61
Conversation
Ensure we resolve references for elbv2 rule.actions.forwardconfig.targetgroups
|
@michaelhtm: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| references: | ||
| resource: TargetGroup | ||
| path: Status.ACKResourceMetadata.ARN | ||
| Actions.ForwardConfig.TargetGroups.TargetGroupARN: |
There was a problem hiding this comment.
Q: Should this not result in a change to the CRD?
There was a problem hiding this comment.
The CRD already had this field, but it was not implemented in references.go..
The reason for that was because the actual struct used here already had "references" implemented
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #2641
Description of changes:
Ensure we resolve references for elbv2
rule.actions.forwardconfig.targetgroupsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.